linux-kernel - Re: [PATCH 11/14] USB: serial: mos7840: move constants to right

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160228124615.GD10265@localhost>
Date:	Sun, 28 Feb 2016 13:46:15 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	Mathieu OTHACEHE <m.othacehe@...il.com>, johan@...nel.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 11/14] USB: serial: mos7840: move constants to right

On Mon, Feb 01, 2016 at 01:37:33PM +0100, Bjørn Mork wrote:
> Mathieu OTHACEHE <m.othacehe@...il.com> writes:
> > On Sun, Jan 31, 2016 at 10:33:54PM +0100, Bjørn Mork wrote:
> >
> >> I feel I'm missing something here, so I have to ask the stupid question:
> >> What could possibly be the benefit here?  Is it faster? Safer?  Easier
> >> to read?
> >
> > I don't think it will be faster or safer, maybe easier to read. But the point is to remove the
> > warnings produced by the file scripts/coccinelle/misc/compare_const_fl.cocci when
> > running make coccicheck.
> 
> Making a tool happy is never going to be a valid reason for anything.
> If it were, then you would not be necessary...

Agreed.

> Luckily you still are. Your task is adding some intelligence to the
> output of the script.  That means that you should look at the output and
> describe how it improves the code in a way that makes me understand it.
> And I can be pretty slow :)
> 
> If you can't do that, then there is a high probability that the script
> didn't improve anything.

Looking through some of these (resent) chunks now, it's clear that some
arguable do not even improve readability.

I'll try to go through them and only pick the ones that do.

Thanks,
Johan