linux-kernel - Re: [PATCH] device property: don't bother the drivers with struct property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160229125948.GA1794@lahna.fi.intel.com>
Date:	Mon, 29 Feb 2016 14:59:48 +0200
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Lee Jones <lee.jones@...aro.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Thierry Reding <treding@...dia.com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH] device property: don't bother the drivers with struct
 property_set

On Fri, Feb 26, 2016 at 01:20:00PM +0200, Heikki Krogerus wrote:
> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
> 
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Nice!

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>