linux-kernel - Re: [PATCH] netfilter: xt_osf: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160229130020.GA16348@salvia>
Date:	Mon, 29 Feb 2016 14:00:20 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Patrick McHardy <kaber@...sh.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: xt_osf: remove unused variable

On Tue, Feb 23, 2016 at 01:40:10PM +0530, Sudip Mukherjee wrote:
> While building with W=1 we got the warning:
> net/netfilter/xt_osf.c:265:9: warning: variable 'loop_cont' set but not used
> 
> The local variable loop_cont was only initialized and then assigned a
> value but was never used or checked after that.
> While removing the variable, the case of OSFOPT_TS was not removed so
> that it will serve as a reminder to us that we can do something in that
> particular case.

Applied, thanks.