linux-kernel - Re: [PATCH v7] watchdog: Add watchdog timer support for the WinSystems EBC-C384

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 28 Feb 2016 20:40:48 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	William Breathitt Gray <vilhelm.gray@...il.com>, wim@...ana.be
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] watchdog: Add watchdog timer support for the
 WinSystems EBC-C384

Hi,

On 02/28/2016 08:20 PM, William Breathitt Gray wrote:
> The WinSystems EBC-C384 has an onboard watchdog timer. The timeout range
> supported by the watchdog timer is 1 second to 255 minutes. Timeouts
> under 256 seconds have a 1 second granularity, while the rest have a 1
> minute granularity.
>
> This driver adds watchdog timer support for this onboard watchdog timer.
> The timeout may be configured via the timeout module parameter.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
> Changes in v7:
>    - Make sure timeout member is in seconds resolution despite minutes
>      granularity
>

For Wim's benefit:

You forgot the actual change. The follow-up RESEND is really confusing;
RESEND indicates that no change was made, and leaves it up to us to figure
out what is going on. If something like this happens again, just add
another rev and add a note indicating what has (really) changed.

Also, when you make code changes, please drop previous Reviewed-by: or
Acked-by: tags unless you got explicit permission from the reviewer
to keep the tag.

Thanks,
Guenter