linux-kernel - Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D55D1D.8090701@raspberrypi.org>
Date:	Tue, 1 Mar 2016 09:13:01 +0000
From:	Phil Elwell <phil@...pberrypi.org>
To:	Eric Anholt <eric@...olt.net>,
	Linus Walleij <linus.walleij@...aro.org>
CC:	<linux-rpi-kernel@...ts.infradead.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>, <linux-gpio@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull"
 parsing

On 01/03/2016 01:30, Eric Anholt wrote:
> From: Phil Elwell <phil@...pberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@...olt.net>
> Cc: stable@...r.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
>
> Phil, any chance you could start putting Signed-off-by lines on your
> kernel commits?
>
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 0f5997c..08b1d93 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -779,7 +779,7 @@ static int bcm2835_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
>  		}
>  		if (num_pulls) {
>  			err = of_property_read_u32_index(np, "brcm,pull",
> -					(num_funcs > 1) ? i : 0, &pull);
> +					(num_pulls > 1) ? i : 0, &pull);
>  			if (err)
>  				goto out;
>  			err = bcm2835_pctl_dt_node_to_map_pull(pc, np, pin,
Signed-off-by: Phil Elwell <phil@...pberrypi.org>