linux-kernel - Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 14:09:22 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Eric Anholt <eric@...olt.net>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Lee Jones <lee@...nel.org>, linux-gpio@...r.kernel.org,
	Phil Elwell <phil@...pberrypi.org>, stable@...r.kernel.org
Subject: Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull"
 parsing

On 02/29/2016 06:30 PM, Eric Anholt wrote:
> From: Phil Elwell <phil@...pberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@...olt.net>
> Cc: stable@...r.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.

I'd argue that part (b) only applies if the s-o-b line is present in the 
original, otherwise I'm not sure how it's clear the author intended to 
publish their source under the license in question. That's why I've 
always beedn careful to go back and ask the original author to give 
their s-o-b, like you did. Some commits at least in the earlier Pi 
Foundation kernels also clearly had incorrect git author values, or were 
squashed together forms of multiple peoples' work:-(

Luckily it's a moot point since Phil gave his s-o-b.

Reviewed-by: Stephen Warren <swarren@...dotorg.org>

Does a similar bug exist in any other pinctrl drivers?