linux-kernel - Re: [PATCH] xfs: remove impossible condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160301120814.GA5217@infradead.org>
Date:	Tue, 1 Mar 2016 04:08:14 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, cmaiolino@...hat.com,
	darrick.wong@...cle.com, namjae.jeon@...sung.com,
	bfoster@...hat.com, sandeen@...deen.net, xfs@....sgi.com,
	billodo@...hat.com
Subject: Re: [PATCH] xfs: remove impossible condition

On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote:
> bp_release is set to 0 just before the breakpoint of the for loop before
> the conditional check (in line 458). The other breakpoint is a goto that
> skips the dead code.

Yes, this looks correct:

Reviewed-by: Christoph Hellwig <hch@....de>

The whole code around this is rather grotty and could use some more
work, though..