linux-kernel - Re: [PATCH] xfs: remove impossible condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D597D5.3040002@osg.samsung.com>
Date:	Tue, 01 Mar 2016 13:23:33 +0000
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	linux-kernel@...r.kernel.org, cmaiolino@...hat.com,
	darrick.wong@...cle.com, namjae.jeon@...sung.com,
	bfoster@...hat.com, sandeen@...deen.net, xfs@....sgi.com,
	billodo@...hat.com
Subject: Re: [PATCH] xfs: remove impossible condition

On 01/03/16 12:08, Christoph Hellwig wrote:
> On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote:
>> bp_release is set to 0 just before the breakpoint of the for loop before
>> the conditional check (in line 458). The other breakpoint is a goto that
>> skips the dead code.
> 
> Yes, this looks correct:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> The whole code around this is rather grotty and could use some more
> work, though..
> 

Thanks for the review Christoph!

If you have some specific things in mind that I could fix in the code around
this, I am happy to add it to my ToDo list. Or I can continue reading it and
let you know of anything I see, so you can confirm before I try to fix it.

Regards,
Luis