linux-kernel - RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7d52fc731a14f28b207ccf4470f6a43@SC-EXCH04.marvell.com>
Date:	Tue, 1 Mar 2016 17:08:38 +0000
From:	Amitkumar Karwar <akarwar@...vell.com>
To:	Marcel Holtmann <marcel@...tmann.org>
CC:	BlueZ development <linux-bluetooth@...r.kernel.org>,
	Nishant Sarmukadam <nishants@...vell.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Cathy Luo <cluo@...vell.com>,
	Ganapathi Bhat <gbhat@...vell.com>
Subject: RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for
 Marvell

Hi Marcel,

> > +
> > +	kfree(skb);
> > +	BT_INFO("leave dnld_fw\n");
> > +
> > +	return ret;
> > +}
> 
> I think it would help if you explain on how the firmware download for
> your UART devices work. I have the feeling we need a bit better core
> handling in this case and not end up hacking it in this way.
> 
> > +

I have explained our firmware download mechanism in attached text file.
I will shortly send V3 patch which address your review comments. Let me know if you have any suggestions.

Regards,
Amit

View attachment "Marvell_UART_FW_download.txt" of type "text/plain" (1592 bytes)