lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Mar 2016 17:10:29 +0000 (UTC) From: Paul Walmsley <paul@...an.com> To: Bjorn Andersson <bjorn.andersson@...aro.org>, Andy Gross <andy.gross@...aro.org> cc: David Brown <david.brown@...aro.org>, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] soc: qcom: smp2p: Use memset_io to zero out new entries On Thu, 25 Feb 2016, Andy Gross wrote: > On Thu, Feb 25, 2016 at 08:17:37AM -0800, Bjorn Andersson wrote: > > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org> > > --- > > drivers/soc/qcom/smp2p.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > > index f1eed7f9dd67..61df598444e6 100644 > > --- a/drivers/soc/qcom/smp2p.c > > +++ b/drivers/soc/qcom/smp2p.c > > @@ -379,7 +379,7 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom_smp2p *smp2p) > > return PTR_ERR(out); > > } > > > > - memset(out, 0, sizeof(*out)); > > + memset_io(out, 0, sizeof(*out)); > > out->magic = SMP2P_MAGIC; > > out->local_pid = smp2p->local_pid; > > out->remote_pid = smp2p->remote_pid; > > Good catch. I'll add this fix for the pull. Folks, is qmem_smem_get() intended to return pointers to device-mapped memory, as implied by this change? If so, shouldn't the return type of qmem_smem_get() et al. be void __iomem * rather than void *? - Paul
Powered by blists - more mailing lists