linux-kernel - Re: [PATCH] thermal: trace: migrating thermal traces to use TRACE_DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160301132006.1cda539c@gandalf.local.home>
Date:	Tue, 1 Mar 2016 13:20:06 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Michele Di Giorgio <michele.digiorgio@....com>
Cc:	linux-pm@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Javi Merino <javi.merino@....com>,
	linux-kernel@...r.kernel.org,
	Punit Agrawal <punit.agrawal@....com>,
	Eduardo Valentin <edubezval@...il.com>
Subject: Re: [PATCH] thermal: trace: migrating thermal traces to use
 TRACE_DEFINE_ENUM() macros

On Tue,  1 Mar 2016 17:38:54 +0000
Michele Di Giorgio <michele.digiorgio@....com> wrote:

> Userspace tools are not aware of how to convert the enums provided by
> the tracepoints to their corresponding strings.
> 
> Adding TRACE_DEFINE_ENUM() macros allows to make the enums available
> to userspace to let the tools know what those enum values represent.
> 
> In particular, for thermal zone trip types what we obtained before was
> something like:
> 
> kworker/1:1-460   [001]   320.372732: thermal_zone_trip:    thermal_zone=soc
> 				id=0 trip=1 trip_type=1
> 
> Unfortunately, userspace tools do not know how to convert enum values to
> strings and as a consequence they can only forward the enum value to the
> output. By using TRACE_DEFINE_ENUM() macros for thermal traces we get the
> following trace line:
> 
> kworker/1:1-460   [001]   320.372732: thermal_zone_trip:    thermal_zone=soc
> 				id=0 trip=1 trip_type=PASSIVE
> 
> Userspace tools are now able to better understand the meaning of the trip_type
> and provide the user with more readable information.
> 

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve