linux-kernel - Re: [PATCH v2 0/2] arm64/efi: query Secure Boot status according to UEFI spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160302133846.GH2649@codeblueprint.co.uk>
Date:	Wed, 2 Mar 2016 13:38:46 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Linn Crosetto <linn@....com>
Cc:	ard.biesheuvel@...aro.org, roy.franz@...aro.org, mingo@...nel.org,
	mark.rutland@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] arm64/efi: query Secure Boot status according to
 UEFI spec

On Thu, 25 Feb, at 05:18:13PM, Linn Crosetto wrote:
> This series modifies the function that queries the status of UEFI Secure Boot
> in the EFI stub to match the UEFI specification, and allow the caller to
> determine if it is enabled, disabled, or in an unknown state due to an
> unexpected error from GetVariable().
> 
> v2:
> 
>  - Add return values for unexpected errors
>  - Split changes into two patches
> 
> Linn Crosetto (2):
>   arm64/efi: report unexpected errors when determining Secure Boot status
>   arm64/efi: check SetupMode when determining Secure Boot status
> 
>  drivers/firmware/efi/libstub/arm-stub.c | 49 +++++++++++++++++++++++++--------
>  1 file changed, 37 insertions(+), 12 deletions(-)

Both of these look fine to me.

Mark, since you gave feedback on the first version, are you happy with
v2?