linux-kernel - [PATCH] perf tools: fix incorrect argument order in calls to get_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed,  2 Mar 2016 15:02:23 +0000
From:	Colin King <colin.king@...onical.com>
To:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Martin Liška <mliska@...e.cz>,
	Bart Van Assche <bart.vanassche@...disk.com>,
	David Ahern <dsahern@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] perf tools: fix incorrect argument order in calls to get_common_field

From: Colin Ian King <colin.king@...onical.com>

Although the arguments are not currently being used, there are three
places where the size and offset arguments are being passed in the
wrong order, so fix these.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 tools/perf/util/trace-event-parse.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index 33b52ea..2c04317 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -56,7 +56,7 @@ int common_lock_depth(struct scripting_context *context)
 	static int size;
 	int ret;
 
-	ret = get_common_field(context, &size, &offset,
+	ret = get_common_field(context, &offset, &size,
 			       "common_lock_depth");
 	if (ret < 0)
 		return -1;
@@ -70,7 +70,7 @@ int common_flags(struct scripting_context *context)
 	static int size;
 	int ret;
 
-	ret = get_common_field(context, &size, &offset,
+	ret = get_common_field(context, &offset, &size,
 			       "common_flags");
 	if (ret < 0)
 		return -1;
@@ -84,7 +84,7 @@ int common_pc(struct scripting_context *context)
 	static int size;
 	int ret;
 
-	ret = get_common_field(context, &size, &offset,
+	ret = get_common_field(context, &offset, &size,
 			       "common_preempt_count");
 	if (ret < 0)
 		return -1;
-- 
2.7.0