linux-kernel - Re: [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" compatible nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 14:44:22 -0600
From:	Rob Herring <robh+dt@...nel.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	"arm@...nel.org" <arm@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Heiko Stuebner <heiko@...ech.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <andy.gross@...aro.org>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	David Brown <david.brown@...aro.org>,
	Pawel Moll <pawel.moll@....com>, Wei Xu <xuwei5@...ilicon.com>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Mark Rutland <mark.rutland@....com>, linux-soc@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" compatible nodes

On Mon, Feb 29, 2016 at 9:57 PM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> The "arm,amba-bus" string in the of_default_bus_match_table is
> ambiguous.  This prepares for killing it off in a long run.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  arch/arm/boot/dts/axm55xx.dtsi             | 2 +-
>  arch/arm/boot/dts/exynos3250.dtsi          | 2 +-
>  arch/arm/boot/dts/exynos4.dtsi             | 2 +-
>  arch/arm/boot/dts/exynos4415.dtsi          | 2 +-
>  arch/arm/boot/dts/exynos5250.dtsi          | 2 +-
>  arch/arm/boot/dts/exynos5420.dtsi          | 2 +-
>  arch/arm/boot/dts/exynos5440.dtsi          | 2 +-
>  arch/arm/boot/dts/hi3620.dtsi              | 2 +-
>  arch/arm/boot/dts/hip01.dtsi               | 2 +-
>  arch/arm/boot/dts/hisi-x5hd2.dtsi          | 2 +-
>  arch/arm/boot/dts/qcom-apq8064.dtsi        | 2 +-
>  arch/arm/boot/dts/qcom-msm8660.dtsi        | 2 +-
>  arch/arm/boot/dts/qcom-msm8960.dtsi        | 2 +-
>  arch/arm/boot/dts/rk3036.dtsi              | 2 +-
>  arch/arm/boot/dts/rk3228.dtsi              | 2 +-
>  arch/arm/boot/dts/rk3288.dtsi              | 2 +-
>  arch/arm/boot/dts/rk3xxx.dtsi              | 2 +-
>  arch/arm/boot/dts/s5pv210.dtsi             | 2 +-
>  arch/arm/boot/dts/socfpga.dtsi             | 2 +-
>  arch/arm/boot/dts/socfpga_arria10.dtsi     | 2 +-
>  arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 2 +-
>  arch/arm/boot/dts/ste-u300.dts             | 2 +-
>  arch/arm/boot/dts/versatile-ab.dts         | 2 +-
>  23 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi
> index ea288f0..8da4582 100644
> --- a/arch/arm/boot/dts/axm55xx.dtsi
> +++ b/arch/arm/boot/dts/axm55xx.dtsi
> @@ -107,7 +107,7 @@
>                 };
>
>                 amba {
> -                       compatible = "arm,amba-bus";
> +                       compatible = "arm,amba-bus", "simple-bus";

Actually, I would remove arm,amba-bus completely to prevent its
spread. Both have been matched since ARM DT support began in the
kernel. AFAICT, FreeBSD only uses simple-bus. If so, then this patch
fixes FreeBSD on these systems (if that was the only issue).

Rob