linux-kernel - Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFuL6xrtjyWTp2AF=4oMMg95QEX+jPoi9kOXUaouvDfb15g@mail.gmail.com>
Date:	Fri, 4 Mar 2016 15:09:31 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Alexandre Courbot <acourbot@...dia.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask

On Wed, Mar 2, 2016 at 6:30 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 01 March 2016 13:32:43 Alexandre Courbot wrote:
>>          */
>> -       if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA))) {
>> +       if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA)))
>>                 host->dma_mask = DMA_BIT_MASK(64);
>> -               mmc_dev(mmc)->dma_mask = &host->dma_mask;
>> -       }
>> +
>> +       if (host->dma_mask &&
>> +           dma_set_mask_and_coherent(mmc_dev(mmc), host->dma_mask))
>> +               pr_warn("%s: cannot set DMA mask\n", mmc_hostname(mmc));
>>
>
> Looks good,
>
> Acked-by: Arnd Bergmann <arnd@...db.de>

Withdrawing this patch after discussing with Arnd. The test detects
devices that are not capable of DMA, so it makes no sense to call a
DMA function right after that.

A better solution to the problem this patch tried to solve is on the way.