linux-kernel - Re: [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160304060811.GA30681@linux.vnet.ibm.com>
Date:	Fri, 4 Mar 2016 11:38:12 +0530
From:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:	Petr Mladek <pmladek@...e.com>
Cc:	linuxppc-dev@...abs.org, Balbir Singh <bsingharora@...il.com>,
	duwe@....de, linux-kernel@...r.kernel.org, rostedt@...dmis.org,
	jeyu@...hat.com, jkosina@...e.cz, live-patching@...r.kernel.org,
	mbenes@...e.cz, Torsten Duwe <duwe@...e.de>
Subject: Re: [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc

* Petr Mladek <pmladek@...e.com> [2016-03-03 17:52:01]:

> From: Balbir Singh <bsingharora@...il.com>
> 
> Changelog v4:
> 	1. Renamed klp_matchaddr() to klp_get_ftrace_location()
> 	   and used it just to convert the function address.
> 	2. Synced klp_write_module_reloc() with s390(); made it
> 	   inline, no error message, return -ENOSYS
> 	3. Added an error message when including
> 	   powerpc/include/asm/livepatch.h without HAVE_LIVEPATCH
> 	4. Update some comments.
> Changelog v3:
> 	1. Moved -ENOSYS to -EINVAL in klp_write_module_reloc
> 	2. Moved klp_matchaddr to use ftrace_location_range
> Changelog v2:
> 	1. Implement review comments by Michael
> 	2. The previous version compared _NIP from the
> 	   wrong location to check for whether we
> 	   are going to a patched location
> 
> This applies on top of the patches posted by Michael
> https://patchwork.ozlabs.org/patch/589791/
> 
> It enables livepatching. This takes patch 6/8 and 7/8 of v8 as the base.
> (See the reference [1] below) and adds logic for checking offset ranges
> in livepatch with ftrace_location_range.
> 
> I tested the sample in the livepatch
> 
> Signed-off-by: Torsten Duwe <duwe@...e.de>
> Signed-off-by: Balbir Singh <bsingharora@...il.com>
> Signed-off-by: Petr Mladek <pmladek@...e.com>

Reviewed-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>

I tried it, with the sample livepatch module.

Tested-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>



Thanks,
Kamalesh.