linux-kernel - Re: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mvqeowx1.fsf@eliezer.anholt.net>
Date:	Fri, 04 Mar 2016 11:39:06 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Mark Rutland <mark.rutland@....com>
Cc:	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

Mark Rutland <mark.rutland@....com> writes:

> On Fri, Mar 04, 2016 at 10:55:03AM -0800, Eric Anholt wrote:
>> Mark Rutland <mark.rutland@....com> writes:
>> 
>> > On Fri, Mar 04, 2016 at 10:39:29AM -0800, Eric Anholt wrote:
>> >> For now this doesn't support the new hardware present on the Pi 3 (BT,
>> >> wifi, GPIO expander).  Since the GPIO expander isn't supported, we
>> >> also don't have the LEDs like the other board files do.
>> >> 
>> >> Signed-off-by: Eric Anholt <eric@...olt.net>
>> >> ---
>> >>  arch/arm/boot/dts/Makefile            |  3 +-
>> >>  arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 22 ++++++++++++
>> >>  arch/arm/boot/dts/bcm2837.dtsi        | 68 +++++++++++++++++++++++++++++++++++
>> >>  3 files changed, 92 insertions(+), 1 deletion(-)
>> >>  create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> >>  create mode 100644 arch/arm/boot/dts/bcm2837.dtsi
>> >
>> >> +	timer {
>> >> +		compatible = "arm,armv7-timer";
>> >> +		interrupt-parent = <&local_intc>;
>> >> +		interrupts = <0>, // PHYS_SECURE_PPI
>> >> +			     <1>, // PHYS_NONSECURE_PPI
>> >> +			     <3>, // VIRT_PPI
>> >> +			     <2>; // HYP_PPI
>> >> +		always-on;
>> >> +	};
>> >
>> > Are the CPUs in an always-on power domain? Or is it jsut that the kernel
>> > doesn't perform power management of CPUs?
>> >
>> > The always-on proeprty is only intended for the former.
>> 
>> The kernel doesn't get to do power management of CPUs.  We only have
>> control of power domains through the firmware, and the firmware's
>> keeping the CPU domain on.
>
> So there is no way that the CPUs could request for the firmare to place
> them in a state where the timer would lose context (but other events
> coukd wake them up), even if they don't do that today?

I don't see any mechanism in the RPi firmware for the ARM to request
suspend or anything like that.  Enabling something like that would
definitely require an updated DT, to enable a driver that talks to the
firmware to make requests like that.

(Note that this is the same timer setup we have in bcm2836.dtsi)

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)