linux-kernel - Re: [PATCH v2 3/8] perf tools: Use own hpp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160305181722.GA17746@krava.redhat.com>
Date:	Sat, 5 Mar 2016 19:17:22 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode

On Fri, Mar 04, 2016 at 11:59:37PM +0900, Namhyung Kim wrote:

SNIP

> @@ -1150,20 +1159,29 @@ static int hists__hierarchy_insert_entry(struct hists *hists,
>  					 struct hist_entry *he)
>  {
>  	struct perf_hpp_fmt *fmt;
> +	struct perf_hpp_list_node *node;
>  	struct hist_entry *new_he = NULL;
>  	struct hist_entry *parent = NULL;
>  	int depth = 0;
>  	int ret = 0;
>  
> -	hists__for_each_sort_list(hists, fmt) {
> -		if (!perf_hpp__is_sort_entry(fmt) &&
> -		    !perf_hpp__is_dynamic_entry(fmt))
> -			continue;
> -		if (perf_hpp__should_skip(fmt, hists))
> +	list_for_each_entry(node, &hists->hpp_formats, list) {
> +		bool skip = false;
> +
> +		perf_hpp_list__for_each_sort_list(&node->hpp, fmt) {
> +			if (!perf_hpp__is_sort_entry(fmt) &&
> +			    !perf_hpp__is_dynamic_entry(fmt))
> +				skip = true;
> +			if (perf_hpp__should_skip(fmt, hists))
> +				skip = true;
> +			if (skip)
> +				break;

could we add skip bool into node and initialize it gradually in add_hierarchy_fmt?

jirka