lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 5 Mar 2016 21:50:16 +0100
From:	luca abeni <luca.abeni@...tn.it>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Juri Lelli <juri.lelli@....com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/deadline: remove dl_new from sched_dl_entity

On Sat, 5 Mar 2016 09:50:59 +0100
Ingo Molnar <mingo@...nel.org> wrote:

> 
> * Luca Abeni <luca.abeni@...tn.it> wrote:
> 
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index 57b939c..e0c4456 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -352,7 +352,14 @@ static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se,
> >  	struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
> >  	struct rq *rq = rq_of_dl_rq(dl_rq);
> >  
> > -	WARN_ON(!dl_se->dl_new || dl_se->dl_throttled);
> > +	WARN_ON(dl_time_before(rq_clock(rq), dl_se->deadline));
> > +
> > +	/* We are racing with the deadline timer. So, do nothing because
> > +	   the deadline timer handler will take care of properly recharging
> > +	   the runtime and postponing the deadline
> > +	 */
> > +	if(dl_se->dl_throttled)
> > +		return;
> 
> Obligatory:
> 
> Please use the customary (multi-line) comment style:
[...]

Sorry about that (and other similar issues). I'll fix all the
coding style issues and resubmit on Monday.


		Thanks,
			Luca

> 
>   /*
>    * Comment .....
>    * ...... goes here.
>    */
> 
> ... specified in Documentation/CodingStyle.
> 
> >  static void switched_to_dl(struct rq *rq, struct task_struct *p)
> >  {
> > +	if (dl_time_before(p->dl.deadline, rq_clock(rq))) {
> > +		setup_new_dl_entity(&p->dl, &p->dl);
> > +	}
> 
> Obligatory:
> 
> Please don't use curly braces around single statements.
> 
> Thanks,
> 
> 	Ingo
> 
> 

Powered by blists - more mailing lists