linux-kernel - Re: [PATCH] klp: remove superfluous errors in asm/livepatch.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1603062211300.3656@cbobk.fhfr.pm>
Date:	Sun, 6 Mar 2016 22:13:56 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	Josh Poimboeuf <jpoimboe@...hat.com>
cc:	Miroslav Benes <mbenes@...e.cz>, sjenning@...hat.com,
	vojtech@...e.com, pmladek@...e.cz, mpe@...erman.id.au,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] klp: remove superfluous errors in asm/livepatch.h

On Fri, 4 Mar 2016, Josh Poimboeuf wrote:

> > There is an #error in asm/livepatch.h for both x86 and s390 in
> > !CONFIG_LIVEPATCH cases. It does not make much sense as pointed out by
> > Michael Ellerman. One can happily include asm/livepatch.h with
> > CONFIG_LIVEPATCH. Remove it as useless.
> > 
> > Suggested-by: Michael Ellerman <mpe@...erman.id.au>
> > Signed-off-by: Miroslav Benes <mbenes@...e.cz>
> 
> Looks fine to me.  

Thanks. I consider this to be your Ack then :) (if you disagree, please 
shout loudly).

> While we're at it, do we even need the '#ifdef CONFIG_LIVEPATCH' in 
> these files?  And in include/linux/livepatch.h?

You are right, this seems indeed completely unnecessary. I'll remove it 
for 4.6 as well, if noone has any objections.

-- 
Jiri Kosina
SUSE Labs