linux-kernel - RE: [v3 PATCH 1/3] panic: Change nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Mar 2016 10:53:51 +0000
From:	河合英宏 / KAWAI，HIDEHIRO 
	<hidehiro.kawai.ez@...achi.com>
To:	"'Borislav Petkov'" <bp@...en8.de>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Mingarelli <thomas.mingarelli@....com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Corey Minyard <minyard@....org>,
	Javi Merino <javi.merino@....com>,
	Michal Hocko <mhocko@...e.com>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"Steven Rostedt (Red Hat)" <rostedt@...dmis.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Michal Nazarewicz" <mina86@...a86.com>,
	Michal Hocko <mhocko@...nel.org>,
	"Vitaly Kuznetsov" <vkuznets@...hat.com>,
	HATAYAMA Daisuke <d.hatayama@...fujitsu.com>,
	Gobinda Charan Maji <gobinda.cemk07@...il.com>,
	Tejun Heo <tj@...nel.org>,
	Nicolas Iooss <nicolas.iooss_linux@....org>,
	"openipmi-developer@...ts.sourceforge.net" 
	<openipmi-developer@...ts.sourceforge.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Guenter Roeck <linux@...ck-us.net>
Subject: RE: [v3 PATCH 1/3] panic: Change nmi_panic from macro to function

> From: Borislav Petkov [mailto:bp@...en8.de]
> On Thu, Mar 03, 2016 at 07:57:44PM +0900, Hidehiro Kawai wrote:
> > Change nmi_panic() macro to a normal function for the portability.
> 
> portability?

I wanted to say encapsulating things into a function makes modules
only have to know about the function. Modules don't need to know
all things in the macro.  But I thought again, and `portability'
was not appropriate.

However, this patch set has been queued into -mm now.  So I'll
leave this if not necessary.

Regards,
Hidehiro Kawai

> > Also, export it for modules.
> >
> > Changes since v2:
> > - Make nmi_panic receive a single string instead of printf style args
> >
> > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Borislav Petkov <bp@...e.de>
> > Cc: Michal Nazarewicz <mina86@...a86.com>
> > Cc: Michal Hocko <mhocko@...e.com>
> > Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
> > Cc: Nicolas Iooss <nicolas.iooss_linux@....org>
> > Cc: Javi Merino <javi.merino@....com>
> > Cc: Gobinda Charan Maji <gobinda.cemk07@...il.com>
> > Cc: "Steven Rostedt (Red Hat)" <rostedt@...dmis.org>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
> > Cc: HATAYAMA Daisuke <d.hatayama@...fujitsu.com>
> > Cc: Tejun Heo <tj@...nel.org>
> > ---
> >  include/linux/kernel.h |   21 +--------------------
> >  kernel/panic.c         |   20 ++++++++++++++++++++
> >  2 files changed, 21 insertions(+), 20 deletions(-)
> 
> Acked-by: Borislav Petkov <bp@...e.de>
> 
> --
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.