linux-kernel - RE: [Openipmi-developer] [v3 PATCH 3/3] hpwdt: Use nmi_panic() when kernel panics in NMI handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04EAB7311EE43145B2D3536183D1A84454B189CD@GSjpTKYDCembx31.service.hitachi.net>
Date:	Mon, 7 Mar 2016 11:07:30 +0000
From:	河合英宏 / KAWAI，HIDEHIRO 
	<hidehiro.kawai.ez@...achi.com>
To:	河合英宏 / KAWAI，HIDEHIRO 
	<hidehiro.kawai.ez@...achi.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Mingarelli <thomas.mingarelli@....com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Corey Minyard <minyard@....org>
CC:	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Hocko <mhocko@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	"openipmi-developer@...ts.sourceforge.net" 
	<openipmi-developer@...ts.sourceforge.net>,
	Guenter Roeck <linux@...ck-us.net>
Subject: RE: [Openipmi-developer] [v3 PATCH 3/3] hpwdt: Use nmi_panic()
 when kernel panics in NMI handler

> From: Phil Pokorny [mailto:ppokorny@...guincomputing.com]
> 
> While you are in drivers/watchdog/hpwdt.c replacing panic() with
> nmi_panic() can you also fix a few more of the broken strings?  The
> Linux style guide specfiically says NOT to break strings that are user
> visible because it breaks "grep".  So:

Ahh, yes.  I should have fixed this as well as the former case.
But this patch set has already been queued into -mm tree, so
I'll leave this patch if the fix is not important.

Regards,
Hidehiro Kawai

> 
> -       panic("An NMI occurred. Depending on your system the reason "
> +       nmi_panic(regs, "An NMI occurred. Depending on your system the reason "
>                 "for the NMI is logged in any one of the following "
>                 "resources:\n"
>                 "1. Integrated Management Log (IML)\n"
> 
> Should probably be:
> 
> -       panic("An NMI occurred. Depending on your system the reason "
> -                "for the NMI is logged in any one of the following "
> -                "resources:\n"
> +       nmi_panic(regs, "An NMI occurred. Depending on your system the
> reason for the NMI is logged in any one of the following resources:\n"
>                 "1. Integrated Management Log (IML)\n"
> 
> So it's okay to break on "\n", but not in the middle of a line.
> 
> --
> Philip Pokorny, RHCE
> Chief Technology Officer
> PENGUIN COMPUTING, Inc
> www.penguincomputing.com
> 
> Changing the world through technical innovation