linux-kernel - Re: [PATCH] pinctrl: lpc18xx: ensure ngroups is initialized at correct place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYxFm06aCUwf-stH4fmJdqS25Ek=9i0CVwR4JcSYPtLEQ@mail.gmail.com>
Date:	Mon, 7 Mar 2016 10:28:56 +0700
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Joachim Eastwood <manabian@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: lpc18xx: ensure ngroups is initialized at
 correct place

On Thu, Feb 25, 2016 at 12:32 AM, Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> The initialization of ngroups is occurring at the end of the
> first iteration of the outer loop, which means that the
> assignment  pins[ngroups++] = i is potentially indexing into
> a region outside of array pins because ngroups is not initialized.
> Instead, initialize ngroups in the inner loop before the first
> inner loop iteration.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied with Joachim's review tag.

Yours,
Linus Walleij