[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAAtXAHeAM=5sTWQd7AHvwrLPUfaozpMUVe9gYeruzbuass_ZHg@mail.gmail.com>
Date: Mon, 7 Mar 2016 11:47:20 -0800
From: Moritz Fischer <moritz.fischer@...us.com>
To: David Miller <davem@...emloft.net>
Cc: Nicolas Ferre <nicolas.ferre@...el.com>, netdev@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] net: macb: Fix more coding style issues
Hi Joe, David,
On Mon, Mar 7, 2016 at 10:49 AM, David Miller <davem@...emloft.net> wrote:
> From: Moritz Fischer <moritz.fischer@...us.com>
> Date: Mon, 7 Mar 2016 08:17:38 -0800
>
>> @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int first_frag,
>> static int macb_rx(struct macb *bp, int budget)
>> {
>> int received = 0;
>> + int dropped;
>> unsigned int tail;
>> int first_frag = -1;
>>
>> @@ -968,7 +967,6 @@ static int macb_rx(struct macb *bp, int budget)
>> }
>>
>> if (ctrl & MACB_BIT(RX_EOF)) {
>> - int dropped;
>> BUG_ON(first_frag == -1);
>>
>> dropped = macb_rx_frame(bp, first_frag, tail);
>
> I totally disagree with moving local variable declarations up to the
> top-most scope.
>
> It is always best to keep them in the inner-most scope.
Alright, I can back these changes out. Didn't mean to sneak anything in.
Cheers,
Moritz
Powered by blists - more mailing lists