linux-kernel - Re: [PATCH net-next v2 1/3] ipv6: replace global gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUicnXkfF67rhXD684Rfqbtuexa9J4Lwyy8h04cP3G02A@mail.gmail.com>
Date:	Tue, 8 Mar 2016 10:25:23 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Michal Kubecek <mkubecek@...e.cz>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH net-next v2 1/3] ipv6: replace global gc_args with local variable

On Tue, Mar 8, 2016 at 5:44 AM, Michal Kubecek <mkubecek@...e.cz> wrote:
> Global variable gc_args is only used in fib6_run_gc() and functions
> called from it. As fib6_run_gc() makes sure there is at most one
> instance of fib6_clean_all() running at any moment, we can replace
> gc_args with a local variable which will be needed once multiple
> instances (per netns) of garbage collector are allowed.
>
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks.