linux-kernel - Re: [PATCH net-next v2 2/3] ipv6: per netns fib6 walkers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWTuk+b4qn5D6mBoqKeK14jZqqg3usjx6xDQt30O2VyYQ@mail.gmail.com>
Date:	Tue, 8 Mar 2016 10:34:39 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Michal Kubecek <mkubecek@...e.cz>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH net-next v2 2/3] ipv6: per netns fib6 walkers

On Tue, Mar 8, 2016 at 5:44 AM, Michal Kubecek <mkubecek@...e.cz> wrote:
> The IPv6 FIB data structures are separated per network namespace but
> there is still only one global walkers list and one global walker list
> lock. This means changes in one namespace unnecessarily interfere with
> walkers in other namespaces.
>
> Replace the global list with per-netns lists (and give each its own
> lock).
>
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> ---
> v2: get rid of ifdef in ipv6_route_seq_setup_walk(), pass net from
> callers instead

Reviewed-by: Cong Wang <xiyou.wangcong@...il.com>