[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160308042409.GE13692@x1>
Date: Tue, 8 Mar 2016 11:24:09 +0700
From: Lee Jones <lee.jones@...aro.org>
To: Javier Martinez Canillas <javier@....samsung.com>
Cc: linux-kernel@...r.kernel.org, Andi Shyti <andi.shyti@...sung.com>,
linux-samsung-soc@...r.kernel.org,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH 4/4] mfd: max77686: Export OF module alias information
On Fri, 12 Feb 2016, Javier Martinez Canillas wrote:
> When the device is registered via OF, the OF table is used to match the
> driver instead of the I2C device ID table but the entries in the latter
> are used as aliasses to load the module if the driver was not built-in.
>
> This is because the I2C core always reports an I2C module alias instead
> of an OF one but that could change so it is better to always export it.
I do have a set which changes this behaviour.
Annoyingly it is still not applied. :(
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>
> ---
>
> drivers/mfd/max77686.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 2f563d0f83cc..b1ed9ed0828c 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -204,6 +204,7 @@ static const struct of_device_id max77686_pmic_dt_match[] = {
> },
> { },
> };
> +MODULE_DEVICE_TABLE(of, max77686_pmic_dt_match);
>
> static int max77686_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists