linux-kernel - RE: [PATCH] EDAC, sb_edac: Fixed logic error in sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570CC49A75F8F64D9F711A9B9476C48C1FB8AF5B@IRSMSX101.ger.corp.intel.com>
Date:	Tue, 8 Mar 2016 09:18:33 +0000
From:	"Chrzaniuk, Hubert" <hubert.chrzaniuk@...el.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	"Anaczkowski, Lukasz" <lukasz.anaczkowski@...el.com>,
	"mchehab@....samsung.com" <mchehab@....samsung.com>,
	"dougthompson@...ssion.com" <dougthompson@...ssion.com>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver

-----Original Message-----
From: Borislav Petkov [mailto:bp@...en8.de] 
Sent: Monday, March 7, 2016 4:24 PM

> Do I see it correctly this one fixes
> d0cdf9003140 ("EDAC, sb_edac: Add Knights Landing (Xeon Phi gen 2) support")
> and needs to go to Linus now otherwise 4.5 is b0rked on KNL?

Yes, that’s right:
1. d0cdf9003140 is the patch I am referring to
2. EDAC for KNL platform on 4.5 will not cause any problems but will not be functional for DIMMs (only for MCDRAM)

> On a related note, that knl_get_dimm_capacity() is huuuge and hard to
> read and could use some nice cleanups and splitting out functionality
> into helper functions...

Thanks, that is a valid point, it will be refactored in a separate patch.
However it would good to fix what we have now, so I still hope to have the patch merged anyway...

-Hubert