linux-kernel - Re: [PATCH 3/5] gpio: of: Return error if gpio hog configuration failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160308142318.GC9864@ulmo.nvidia.com>
Date:	Tue, 8 Mar 2016 15:23:19 +0100
From:	Thierry Reding <treding@...dia.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	<linus.walleij@...aro.org>, <robh+dt@...nel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-gpio@...r.kernel.org>, <swarren@...dotorg.org>,
	Benoit Parrot <bparrot@...com>,
	Alexandre Courbot <acourbot@...dia.com>
Subject: Re: [PATCH 3/5] gpio: of: Return error if gpio hog configuration
 failed

On Tue, Mar 08, 2016 at 05:32:06PM +0530, Laxman Dewangan wrote:
> If GPIO hog configuration failed while adding OF based
> gpiochip() then return the error instead of ignoring it.
> 
> This helps of properly handling the gpio driver dependency.
> 
> When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
> the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
> ready at this time and gpio_request() for Tegra GPIO driver
> returns error. The error was not causing the Tegra GPIO driver
> to fail as the error was getting ignored.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Cc: Benoit Parrot <bparrot@...com>
> Cc: Alexandre Courbot <acourbot@...dia.com>
> ---
>  drivers/gpio/gpiolib-of.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

Reviewed-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)