linux-kernel - Re: [PATCH 3/6] perf tools: Fix command line filters in hierarchy mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160309091356.GA25692@krava.redhat.com>
Date:	Wed, 9 Mar 2016 10:13:56 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 3/6] perf tools: Fix command line filters in hierarchy
 mode

On Wed, Mar 09, 2016 at 12:06:40AM +0900, Namhyung Kim wrote:
> When a command-line filter was applied in hierarchy mode, output was
> broken especially when filtering on lower level.  The higher level
> entries didn't show up so it's hard to see the result.
> 
> Also it needs to handle multi sort keys in a single level of hierarchy.
> 
> Before:
> 
>   $ perf report --hierarchy -s 'cpu,{dso,comm}' --comms swapper --stdio
>   ...
>   #    Overhead  CPU / Shared Object+Command
>   # ...........  ...........................
>   #
>          13.79%     [kernel.vmlinux]  swapper
>       31.71%     000
>          13.80%     [kernel.vmlinux]  swapper
>           0.43%     [e1000e]          swapper
>          11.89%     [kernel.vmlinux]  swapper
>           9.18%     [kernel.vmlinux]  swapper
> 
> After:
> 
>   #    Overhead  CPU / Shared Object+Command
>   # ...........  ...............................
>   #
>       33.09%     003
>          13.79%     [kernel.vmlinux]  swapper
>       31.71%     000
>          13.80%     [kernel.vmlinux]  swapper
>           0.43%     [e1000e]          swapper
>       21.90%     002
>          11.89%     [kernel.vmlinux]  swapper
>       13.30%     001
>           9.18%     [kernel.vmlinux]  swapper

I'm getting funny numbers when using 'F' toggle in tui mode 

[jolsa@...va perf]$ ./perf report --hierarchy -s 'cpu,{dso,comm}' --comms swapper 

Samples: 254  of event 'cycles:pp', Event count (approx.): 132263887
 Overhead     CPU / Shared Object+Command                                                                                                                     ◆
+ 69.85%      001                                                                                                                                             ▒
+ 44.28%      000                                                                                                                                             ▒
+ 41.62%      002                                                                                                                                             ▒
+ 36.80%      003                                                                                                                                             


[jolsa@...va perf]$ sudo ./perf top --hierarchy -s 'cpu,{dso,comm}' --comms swapper 

 Overhead     CPU / Shared O+Command
+ 320.64%     000
+ 179.91%     002
+ 137.05%     003
+ 88.37%      001


thanks,
jirka