linux-kernel - Re: [PATCH 08/27] mm, vmscan: Make kswapd reclaim in terms of nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160309144529.GB31585@techsingularity.net>
Date:	Wed, 9 Mar 2016 14:45:29 +0000
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Vlastimil Babka <vbabka@...e.cz>
Cc:	Linux-MM <linux-mm@...ck.org>, Rik van Riel <riel@...riel.com>,
	Johannes Weiner <hannes@...xchg.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/27] mm, vmscan: Make kswapd reclaim in terms of nodes

On Thu, Mar 03, 2016 at 02:46:14PM +0100, Vlastimil Babka wrote:
> On 02/23/2016 04:04 PM, Mel Gorman wrote:
> > -static bool zone_balanced(struct zone *zone, int order, bool highorder,
> > +static bool zone_balanced(struct zone *zone, int order,
> >  			unsigned long balance_gap, int classzone_idx)
> >  {
> >  	unsigned long mark = high_wmark_pages(zone) + balance_gap;
> >  
> > -	/*
> > -	 * When checking from pgdat_balanced(), kswapd should stop and sleep
> > -	 * when it reaches the high order-0 watermark and let kcompactd take
> > -	 * over. Other callers such as wakeup_kswapd() want to determine the
> > -	 * true high-order watermark.
> > -	 */
> > -	if (IS_ENABLED(CONFIG_COMPACTION) && !highorder) {
> > -		mark += (1UL << order);
> > -		order = 0;
> > -	}
> > -
> >  	return zone_watermark_ok_safe(zone, order, mark, classzone_idx);
> 
> Did you really intend to remove this or was it due to rebasing on top of
> kcompactd?

It was intentional because kswapd_shrink_node() sets sc.order to 0 when
pages have been reclaimed. There is no guarantee it'll be enough to actually
compact but it's conservative in terms of reclaim. The end result should
be that this check is no longer necessary.

-- 
Mel Gorman
SUSE Labs