linux-kernel - Re: [PATCH v16 02/23] tracing: Add 'hist' event trigger command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457481819.28618.1.camel@tzanussi-mobl.amr.corp.intel.com>
Date:	Tue, 08 Mar 2016 18:03:39 -0600
From:	Tom Zanussi <tom.zanussi@...ux.intel.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	masami.hiramatsu.pt@...achi.com, namhyung@...nel.org,
	josh@...htriplett.org, andi@...stfloor.org,
	mathieu.desnoyers@...icios.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v16 02/23] tracing: Add 'hist' event trigger command

Yep, thanks for fixing these, Steve.

Tom

On Tue, 2016-03-08 at 17:26 -0500, Steven Rostedt wrote:
> FYI,
> 
> -- Steve
> 
> From 65692275fc895f7e2144889cd1335ff037cdb291 Mon Sep 17 00:00:00 2001
> From: "Steven Rostedt (Red Hat)" <rostedt@...dmis.org>
> Date: Tue, 8 Mar 2016 17:17:15 -0500
> Subject: [PATCH] tracing: Fix unsigned comparison to zero in hist trigger code
> 
> Fengguang Wu's bot found two comparisons of unsigned integers to zero. These
> were real bugs, as it would miss error conditions returned to zero.
> 
> trace_events_hist.c:426:6-9: WARNING: Unsigned expression compared with zero: idx < 0
> trace_events_hist.c:568:5-14: WARNING: Unsigned expression compared with zero: n_entries < 0
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> ---
>  kernel/trace/trace_events_hist.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 5aa16224036b..92c9f3666fae 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -734,7 +734,7 @@ static int create_tracing_map_fields(struct hist_trigger_data *hist_data)
>  	struct tracing_map *map = hist_data->map;
>  	struct ftrace_event_field *field;
>  	struct hist_field *hist_field;
> -	unsigned int i, idx;
> +	int i, idx;
>  
>  	for_each_hist_field(i, hist_data) {
>  		hist_field = hist_data->fields[i];
> @@ -1036,7 +1036,7 @@ static int print_entries(struct seq_file *m,
>  {
>  	struct tracing_map_sort_entry **sort_entries = NULL;
>  	struct tracing_map *map = hist_data->map;
> -	unsigned int i, n_entries;
> +	int i, n_entries;
>  
>  	n_entries = tracing_map_sort_entries(map, hist_data->sort_keys,
>  					     hist_data->n_sort_keys,