linux-kernel - Re: [PATCH 1/3] block: introduce device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160310151844.GA8334@lst.de>
Date:	Thu, 10 Mar 2016 16:18:44 +0100
From:	Christoph Hellwig <hch@....de>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...com>,
	linux-block@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 1/3] block: introduce device_add_disk()

On Thu, Mar 10, 2016 at 07:15:19AM -0800, Dan Williams wrote:
> > How are the callers expected to unwind after already having added the
> > disk?
> 
> True, I overlooked making add_disk() unwind-able, will re-spin...

I think this will take more work than we can finish in the next
days.  It would be good to simply respin it without adding the error
propagation.