linux-kernel - Re: [PATCH] serial-uartlite: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160310162044.b7b5cd51@kerio.vanmierlo.com>
Date:	Thu, 10 Mar 2016 16:20:44 +0100
From:	"Maarten Brock" <m.brock@...mierlo.com>
To:	"Sudip Mukherjee" <sudipm.mukherjee@...il.com>,
	"Peter Korsgaard" <jacmet@...site.dk>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Jiri Slaby" <jslaby@...e.com>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	"Sudip Mukherjee" <sudipm.mukherjee@...il.com>
Subject: Re: [PATCH] serial-uartlite: fix build warning

I've created a version 2 of this patch immediately which fixes the warning, 
but somehow this stays ignored. 

Please apply my second patch! 
Maarten 

> We were getting build warnings about:
> drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’:
> drivers/tty/serial/uartlite.c:348:21: warning: assignment discards
>         'const' qualifier from pointer target type
> port->private_data = &uartlite_be;
>                      ^
> drivers/tty/serial/uartlite.c:354:22: warning: assignment discards
>         'const' qualifier from pointer target type
> port->private_data = &uartlite_le;
>                       ^
> 
> Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> ---
> 
> next-20160310 build log at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/114988022
> 
>  drivers/tty/serial/uartlite.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index c9fdfc8..1474c57 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -72,7 +72,7 @@ static void uartlite_outbe32(u32 val, void __iomem *addr)
>  	iowrite32be(val, addr);
>  }
>  
> -static const struct uartlite_reg_ops uartlite_be = {
> +static struct uartlite_reg_ops uartlite_be = {
>  	.in = uartlite_inbe32,
>  	.out = uartlite_outbe32,
>  };
> @@ -87,7 +87,7 @@ static void uartlite_outle32(u32 val, void __iomem *addr)
>  	iowrite32(val, addr);
>  }
>  
> -static const struct uartlite_reg_ops uartlite_le = {
> +static struct uartlite_reg_ops uartlite_le = {
>  	.in = uartlite_inle32,
>  	.out = uartlite_outle32,
>  };
> -- 
> 1.9.1