linux-kernel - Re: runtime regression with "x86/mm/pat: Emulate PAT when it is disabled"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457640261.15454.551.camel@hpe.com>
Date:	Thu, 10 Mar 2016 13:04:21 -0700
From:	Toshi Kani <toshi.kani@....com>
To:	Borislav Petkov <bp@...e.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Richard Purdie <richard.purdie@...uxfoundation.org>,
	Toshi Kani <toshi.kani@...com>,
	Bruce Ashfield <bruce.ashfield@...driver.com>,
	"Hart, Darren" <darren.hart@...el.com>,
	"saul.wold" <saul.wold@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: runtime regression with "x86/mm/pat: Emulate PAT when it is
 disabled"

On Thu, 2016-03-10 at 18:20 +0100, Borislav Petkov wrote:
> On Thu, Mar 10, 2016 at 09:49:51AM -0700, Toshi Kani wrote:
> > This confirms the issue - QEMU's virtual Intel CPU does not support
> > MTRR. 
> > 
> > When MTRR is disabled, the kernel does not call pat_init().
> >  pat_enabled() is still set to true when CONFIG_X86_PAT is set.
> >  CONFIG_X86_PAT depends on CONFIG_MTRR, and assumes that MTRR is
> > enabled. 
> 
> Aha, so "qemu32" model doesn't support MTRRs but "kvm32" does, for
> example. And so do the majority of the other CPU types.
> 
> Paul, can you guys run with something else besides "qemu32"? You can
> even take a 64-bit one and run a 32-bit guest on it.
> 
> :-)
> 

I will send a patch that sets PAT disabled when MTRR is disabled.  This
will solve the Paul's issue.  His qemu32 model does not support PAT,
either.

Ideally, PAT and MTRR features should be managed independently, but this
will require much more effort and will not be easily applied to stable.

Thanks,
-Toshi