linux-kernel - Re: [PATCH] f2fs: support access control via key management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201603101017.Kl8LkQFA%fengguang.wu@intel.com>
Date:	Thu, 10 Mar 2016 10:18:45 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jaegeuk Kim <jaegeuk@...nel.org>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net,
	Jaegeuk Kim <jaegeuk@...nel.org>
Subject: Re: [PATCH] f2fs: support access control via key management

Hi Jaegeuk,

[auto build test ERROR on f2fs/dev]
[also build test ERROR on next-20160309]
[cannot apply to v4.5-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Jaegeuk-Kim/f2fs-support-access-control-via-key-management/20160310-085442
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs dev
config: x86_64-randconfig-s0-03100948 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   fs/f2fs/file.c: In function 'validate_access_key':
>> fs/f2fs/file.c:462:16: error: implicit declaration of function 'request_key' [-Werror=implicit-function-declaration]
     keyring_key = request_key(&key_type_logon, full_key_descriptor, NULL);
                   ^
>> fs/f2fs/file.c:462:29: error: 'key_type_logon' undeclared (first use in this function)
     keyring_key = request_key(&key_type_logon, full_key_descriptor, NULL);
                                ^
   fs/f2fs/file.c:462:29: note: each undeclared identifier is reported only once for each function it appears in
>> fs/f2fs/file.c:466:17: error: dereferencing pointer to incomplete type 'struct key'
     if (keyring_key->type != &key_type_logon) {
                    ^
   In file included from include/uapi/linux/posix_types.h:4:0,
                    from include/uapi/linux/types.h:13,
                    from include/linux/compiler.h:199,
                    from include/linux/linkage.h:4,
                    from include/linux/fs.h:4,
                    from fs/f2fs/file.c:11:
   fs/f2fs/file.c: In function 'f2fs_ioc_keyctl':
   include/linux/stddef.h:7:14: warning: passing argument 6 of 'f2fs_setxattr' makes integer from pointer without a cast [-Wint-conversion]
    #define NULL ((void *)0)
                 ^
   fs/f2fs/file.c:1599:27: note: in expansion of macro 'NULL'
        value, F2FS_KEY_SIZE, NULL, type);
                              ^
   In file included from fs/f2fs/file.c:29:0:
   fs/f2fs/xattr.h:129:19: note: expected 'int' but argument is of type 'void *'
    static inline int f2fs_setxattr(struct inode *inode, int index,
                      ^
   fs/f2fs/file.c:1597:9: error: too many arguments to function 'f2fs_setxattr'
     return f2fs_setxattr(inode, F2FS_XATTR_INDEX_KEY,
            ^
   In file included from fs/f2fs/file.c:29:0:
   fs/f2fs/xattr.h:129:19: note: declared here
    static inline int f2fs_setxattr(struct inode *inode, int index,
                      ^
   cc1: some warnings being treated as errors

vim +/request_key +462 fs/f2fs/file.c

   456		memcpy(full_key_descriptor, F2FS_KEY_DESC_PREFIX,
   457						F2FS_KEY_DESC_PREFIX_SIZE);
   458		sprintf(full_key_descriptor + F2FS_KEY_DESC_PREFIX_SIZE,
   459						"%*phN", F2FS_KEY_SIZE, key);
   460		full_key_descriptor[F2FS_KEY_DESC_PREFIX_SIZE +
   461						(2 * F2FS_KEY_SIZE)] = '\0';
 > 462		keyring_key = request_key(&key_type_logon, full_key_descriptor, NULL);
   463		if (IS_ERR(keyring_key))
   464			return PTR_ERR(keyring_key);
   465	
 > 466		if (keyring_key->type != &key_type_logon) {
   467			printk_once(KERN_WARNING
   468					"%s: key type must be logon\n", __func__);
   469			key_put(keyring_key);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (28618 bytes)