linux-kernel - Re: [PATCH v1 2/3] mailbox: rockchip: Add Rockchip mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY2ZJk-oP20K12qv9YQggQJdGqCWrgMiTyuL+O92eQyR7g@mail.gmail.com>
Date:	Fri, 11 Mar 2016 10:45:55 +0700
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Caesar Wang <wxt@...k-chips.com>, frank.wang@...k-chips.com,
	linux-rockchip@...ts.infradead.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/3] mailbox: rockchip: Add Rockchip mailbox driver

On Tue, Mar 8, 2016 at 1:48 AM, Heiko Stübner <heiko@...ech.de> wrote:
> Hi Jassi,
>
> Am Dienstag, 27. Oktober 2015, 15:31:45 schrieb Caesar Wang:
>> This driver is found on RK3368 SoCs.
>>
>> The Mailbox module is a simple APB peripheral that allows both
>> the Cortex-A53 MCU system to communicate by writing operation to
>> generate interrupt.
>> The registers are accessible by both CPU via APB interface.
>>
>> The Mailbox has the following main features:
>>
>> 1) Support dual-core system: Cortex-A53 and MCU.
>> 2) Support APB interface.
>> 3) Support four mailbox elements, each element includes one data word,
>>    one command word register and one flag bit that can represent
>>    one interrupt.
>> 4) Four interrupts to Cortex-A53.
>> 5) Four interrupts to MCU.
>> 6) Provide 32 lock registers for software to use to indicate whether
>>    mailbox is occupied.
>>
>> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
>
> it seems this patch has fallen through the cracks. Could you take a look if it
> needs anything else?
>
The 0Day kbuild test robot had reported an error in the 3rd patch. I
was expecting another revision. Though that patch shouldn't go via
mailbox tree, so I am picking up the first two patches with a minor
change that is removing the unused variable 'buf_base'.

Thanks.