linux-kernel - Re: [PATCH] iio: adc: imx25-gcq: fix do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 12 Mar 2016 11:09:07 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Markus Pargmann <mpa@...gutronix.de>
Cc:	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	linux-kernel@...r.kernel.org, kernel-testers@...r.kernel.org,
	linux-iio@...r.kernel.org, Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH] iio: adc: imx25-gcq: fix do_div

On 07/03/16 11:06, Sudip Mukherjee wrote:
> On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote:
>> Hi,
>>
>> On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote:
>>> On 03/03/16 12:51, Sudip Mukherjee wrote:
>>>> We are getting build failure with tilepro allmodconfig with the error:
>>>>
>>>> drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div'
>>>> do_div(priv->channel_vref_mv[reg], 1000);
>>>>     ^
>>>>
>>>> include/asm-generic/div64.h:198:17: note: expected 'uint64_t *
>>>> 	{aka long long unsigned int *}' but argument is of type 'u32 *
>>>> 	{aka unsigned int *}'
>>>>
>>>> Create a temporary variable of type u64 and use that in do_div.
>>>>
>>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
>>> Markus, can you take a quick look at this. 
>>
>> Thanks. I think this was already fixed by Arnd.
>> 	"iio: adc/imx25-gcq: move incorrect do_div"
> 
> It should. But I still have the same build failure with next-20160307
> and not only tilepro, even m32r is also having the same build failure.
> 
Lee, did you pick the original fix from Arnd up?

I can take this after the merge window if not.

Jonathan
> regards
> sudip
>