[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160316083950.GU13692@x1>
Date: Wed, 16 Mar 2016 08:39:50 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Markus Pargmann <mpa@...gutronix.de>,
Hartmut Knaack <knaack.h@....de>,
Lars-Peter Clausen <lars@...afoo.de>,
Peter Meerwald <pmeerw@...erw.net>,
linux-kernel@...r.kernel.org, kernel-testers@...r.kernel.org,
linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc: imx25-gcq: fix do_div
On Sat, 12 Mar 2016, Jonathan Cameron wrote:
> On 07/03/16 11:06, Sudip Mukherjee wrote:
> > On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote:
> >> Hi,
> >>
> >> On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote:
> >>> On 03/03/16 12:51, Sudip Mukherjee wrote:
> >>>> We are getting build failure with tilepro allmodconfig with the error:
> >>>>
> >>>> drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div'
> >>>> do_div(priv->channel_vref_mv[reg], 1000);
> >>>> ^
> >>>>
> >>>> include/asm-generic/div64.h:198:17: note: expected 'uint64_t *
> >>>> {aka long long unsigned int *}' but argument is of type 'u32 *
> >>>> {aka unsigned int *}'
> >>>>
> >>>> Create a temporary variable of type u64 and use that in do_div.
> >>>>
> >>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> >>> Markus, can you take a quick look at this.
> >>
> >> Thanks. I think this was already fixed by Arnd.
> >> "iio: adc/imx25-gcq: move incorrect do_div"
> >
> > It should. But I still have the same build failure with next-20160307
> > and not only tilepro, even m32r is also having the same build failure.
> >
> Lee, did you pick the original fix from Arnd up?
>
> I can take this after the merge window if not.
Yes, it's in my tree.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists