linux-kernel - Re: [PATCH] batman-adv: Less function calls in batadv_is_ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160314.152502.1823929263984045274.davem@davemloft.net>
Date:	Mon, 14 Mar 2016 15:25:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	elfring@...rs.sourceforge.net
Cc:	b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
	a@...table.cc, mareklindner@...mailbox.ch, sw@...onwunderlich.de,
	sven@...fation.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCH] batman-adv: Less function calls in
 batadv_is_ap_isolated() after error detection

From: SF Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 11 Mar 2016 13:40:56 +0100

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 11 Mar 2016 13:10:20 +0100
> 
> The variables "tt_local_entry" and "tt_global_entry" were eventually
> checked again despite of a corresponding null pointer test before.
> 
> * Avoid this double check by reordering a function call sequence
>   and the better selection of jump targets.
> 
> * Omit the initialisation for these variables at the beginning then.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

I am assuming Antonio will take this in via his tree.