linux-kernel - Re: [PATCH V7 11/12] arm64: tegra: add soctherm node for Tegra210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160314192500.GE1872@localhost.localdomain>
Date:	Mon, 14 Mar 2016 12:25:01 -0700
From:	Eduardo Valentin <edubezval@...il.com>
To:	Wei Ni <wni@...dia.com>
Cc:	rui.zhang@...el.com, thierry.reding@...il.com,
	MLongnecker@...dia.com, swarren@...dotorg.org,
	mikko.perttunen@...si.fi, linux-tegra@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V7 11/12] arm64: tegra: add soctherm node for Tegra210

On Fri, Mar 11, 2016 at 11:11:34AM +0800, Wei Ni wrote:
> Adds soctherm node for Tegra210, and add cpu,
> gpu, mem, pllx as thermal-zones. Set critical
> trip temp for cpu and gpu thermal zone.
> 
> Signed-off-by: Wei Ni <wni@...dia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 60 ++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index cd4f45ccd6a7..c7ef500a347e 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -3,6 +3,7 @@
>  #include <dt-bindings/memory/tegra210-mc.h>
>  #include <dt-bindings/pinctrl/pinctrl-tegra.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/thermal/tegra124-soctherm.h>
>  
>  / {
>  	compatible = "nvidia,tegra210";
> @@ -802,4 +803,63 @@
>  				(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
>  		interrupt-parent = <&gic>;
>  	};
> +
> +	soctherm: thermal-sensor@0,700e2000 {
> +		compatible = "nvidia,tegra210-soctherm";
> +		reg = <0x0 0x700e2000 0x0 0x1000>;
> +		interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&tegra_car TEGRA210_CLK_TSENSOR>,
> +			<&tegra_car TEGRA210_CLK_SOC_THERM>;
> +		clock-names = "tsensor", "soctherm";
> +		resets = <&tegra_car 78>;
> +		reset-names = "soctherm";
> +		#thermal-sensor-cells = <1>;
> +	};
> +
> +	thermal-zones {
> +		cpu {
> +			polling-delay-passive = <1000>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors =
> +				<&soctherm TEGRA124_SOCTHERM_SENSOR_CPU>;
> +
> +			trips {
> +				cpu_shutdown_trip: shutdown-trip {
> +					temperature = <102500>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +		mem {
> +			polling-delay-passive = <0>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors =
> +				<&soctherm TEGRA124_SOCTHERM_SENSOR_MEM>;


Why no trips for mem? Why should we  care ?

Please have a look on the binding to check for mandatory properties and
sub nodes.

> +		};
> +		gpu {
> +			polling-delay-passive = <1000>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors =
> +				<&soctherm TEGRA124_SOCTHERM_SENSOR_GPU>;
> +
> +			trips {
> +				gpu_shutdown_trip: shutdown-trip {
> +					temperature = <103000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +		pllx {
> +			polling-delay-passive = <0>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors =
> +				<&soctherm TEGRA124_SOCTHERM_SENSOR_PLLX>;

ditto

> +		};
> +	};
>  };
> -- 
> 1.9.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)