linux-kernel - question about pci_enable_msix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1603151123340.2531@hadrien>
Date:	Tue, 15 Mar 2016 11:26:50 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	alex.williamson@...hat.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
cc:	Alexander Gordeev <agordeev@...hat.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Alex Williamson <alex.williamson@...hat.com>
Subject: question about pci_enable_msix_range

Hello,

I was looking at the following code in the file
drivers/vfio/pci/vfio_pci_intrs.c:

                ret = pci_enable_msix_range(pdev, vdev->msix, 1, nvec);
                if (ret < nvec) {
                        if (ret > 0)
                                pci_disable_msix(pdev);
                        kfree(vdev->msix);
                        kfree(vdev->ctx);
                        return ret;
                }

I was wondering what is the point of using a range of 1 .. nvec if there
is going to be a failure if the number of allocated irqs is less than
nvec?

thanks,
julia