linux-kernel - [PATCH v2] regulator: gpio: check return value of of_get_named

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1458141672-3303-1-git-send-email-mihai.d.mihalache@intel.com>
Date:	Wed, 16 Mar 2016 08:21:12 -0700
From:	Mihai Mihalache <mihai.d.mihalache@...el.com>
To:	linux-kernel@...r.kernel.org, broonie@...nel.org,
	lgirdwood@...il.com
Cc:	yousaf.kaukab@...el.com, hans.holmberg@...el.com,
	mihai.d.mihalache@...el.com
Subject: [PATCH v2] regulator: gpio: check return value of of_get_named_gpio

At boot time the regulator driver can be initialized before the
gpio, in which case the call to of_get_named_gpio will return
EPROBE_DEFER. This value is silently passed to regulator_register
which will return success, although the gpio is not registered
(regulator_ena_gpio_request not called) as the value passed is
detected as invalid. The gpio_regulator_probe will therefore
succeed win no gpio requested.

Signed-off-by: Mihai Mihalache <mihai.d.mihalache@...el.com>
Reviewed-by: Hans Holmberg <hans.holmberg@...el.com>
---

History:
	V1:
	- Fix comment from Mark Brown
	V2:
	- Explicit check for EPROBE_DEFER for optional property, 
	  Mark Brown's feedback.

 drivers/regulator/gpio-regulator.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 464018d..f3147ef 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -162,6 +162,8 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np,
 	of_property_read_u32(np, "startup-delay-us", &config->startup_delay);
 
 	config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0);
+	if (config->enable_gpio == -EPROBE_DEFER)
+		return ERR_PTR(-EPROBE_DEFER);
 
 	/* Fetch GPIOs. - optional property*/
 	ret = of_gpio_count(np);
-- 
2.1.4