linux-kernel - [PATCH] qeth: Default to allow promiscuous mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1458234085-217667-1-git-send-email-agraf@suse.de>
Date:	Thu, 17 Mar 2016 18:01:25 +0100
From:	Alexander Graf <agraf@...e.de>
To:	linux-s390@...r.kernel.org
Cc:	Eugene Crosser <Eugene.Crosser@...ibm.com>,
	linux-kernel@...r.kernel.org,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Ursula Braun <ubraun@...ux.vnet.ibm.com>, ihno@...e.de,
	mt@...e.com, pwieczorkiewicz@...e.de
Subject: [PATCH] qeth: Default to allow promiscuous mode

When a qeth device is in bridge role, one of the ports of an adapter can
ask for promiscuous mode and get it enabled.

The default until now was to not allow user space to enable promiscuous mode
without switching sysfs attributes as well though, diverging from usual
network device semantics.

This patch sets the default to allow promiscuous enablement. That way all
existing tools "just work", albeit only one port of an adapter can be in
promiscuous mode at a given time.

Signed-off-by: Alexander Graf <agraf@...e.de>
---
 drivers/s390/net/qeth_l2_sys.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c
index 692db49..98c7ac5 100644
--- a/drivers/s390/net/qeth_l2_sys.c
+++ b/drivers/s390/net/qeth_l2_sys.c
@@ -258,6 +258,10 @@ void qeth_l2_setup_bridgeport_attrs(struct qeth_card *card)
 		return;
 	if (!card->options.sbp.supported_funcs)
 		return;
+
+	/* Allow to set promiscuous by default */
+	card->options.sbp.reflect_promisc = 1;
+
 	if (card->options.sbp.role != QETH_SBP_ROLE_NONE) {
 		/* Conditional to avoid spurious error messages */
 		qeth_bridgeport_setrole(card, card->options.sbp.role);
-- 
1.8.5.6