linux-kernel - Re: [PATCH v1 1/2] ethtool: minor doc update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458260968.3431.0.camel@decadent.org.uk>
Date:	Fri, 18 Mar 2016 00:29:28 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Decotigny <ddecotig@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	David Decotigny <decot@...glers.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Andrew Lunn <andrew@...n.ch>,
	Hadar Hen Zion <hadarh@...lanox.com>,
	Edward Cree <ecree@...arflare.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Thomas Graf <tgraf@...g.ch>,
	Daniel Borkmann <daniel@...earbox.net>,
	Ken-ichirou MATSUZAWA <chamaken@...il.com>,
	Florian Westphal <fw@...len.de>,
	David Herrmann <dh.herrmann@...il.com>
Subject: Re: [PATCH v1 1/2] ethtool: minor doc update

On Thu, 2016-03-17 at 17:03 -0700, David Decotigny wrote:
> From: David Decotigny <decot@...glers.com>
> 
> Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in
>          ETHTOOL_GLINKSETTINGS response to wrong nwords")
> 
> Signed-off-by: David Decotigny <decot@...glers.com>

Reviewed-by: Ben Hutchings <ben@...adent.org.uk>

> ---
>  include/uapi/linux/ethtool.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 2835b07..9222db8 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -1648,9 +1648,9 @@ enum ethtool_reset_flags {
>   *	%ETHTOOL_GLINKSETTINGS: on entry, number of words passed by user
>   *	(>= 0); on return, if handshake in progress, negative if
>   *	request size unsupported by kernel: absolute value indicates
> - *	kernel recommended size and cmd field is 0, as well as all the
> - *	other fields; otherwise (handshake completed), strictly
> - *	positive to indicate size used by kernel and cmd field is
> + *	kernel expected size and all the other fields but cmd
> + *	are 0; otherwise (handshake completed), strictly positive
> + *	to indicate size used by kernel and cmd field stays
>   *	%ETHTOOL_GLINKSETTINGS, all other fields populated by driver. For
>   *	%ETHTOOL_SLINKSETTINGS: must be valid on entry, ie. a positive
>   *	value returned previously by %ETHTOOL_GLINKSETTINGS, otherwise
-- 
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)