linux-kernel - Re: [PATCH v1 0/2] basic ioctl support for netlink sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160320.133122.908035685889835834.davem@davemloft.net>
Date:	Sun, 20 Mar 2016 13:31:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ddecotig@...il.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	nikolay@...ulusnetworks.com, mst@...hat.com, ben@...adent.org.uk,
	jeffrey.t.kirsher@...el.com, decot@...glers.com,
	nicolas.dichtel@...nd.com, andrew@...n.ch, hadarh@...lanox.com,
	ecree@...arflare.com, john.r.fastabend@...el.com,
	herbert@...dor.apana.org.au, tgraf@...g.ch, daniel@...earbox.net,
	chamaken@...il.com, fw@...len.de, dh.herrmann@...il.com
Subject: Re: [PATCH v1 0/2] basic ioctl support for netlink sockets

From: David Decotigny <ddecotig@...il.com>
Date: Thu, 17 Mar 2016 17:03:54 -0700

> This removes the requirement that ethtool be tied to the support
> of a specific L3 protocol, also updates a comment.

You're adding an ioctl handler to netlink sockets, and it is not
at all apparent to me how this influences ethtool handling at all.

Therefore you have to explain this here and in your commit message.