linux-kernel - Re: [PATCH v1 0/2] basic ioctl support for netlink sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG88wWYSzNFPe=9HGy9YUJFcDyk_ZNndoxyz=+=texYmV22_Yg@mail.gmail.com>
Date:	Mon, 21 Mar 2016 10:43:58 -0700
From:	David Decotigny <ddecotig@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	nikolay@...ulusnetworks.com, "Michael S. Tsirkin" <mst@...hat.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	nicolas.dichtel@...nd.com, andrew@...n.ch, hadarh@...lanox.com,
	ecree@...arflare.com, john.r.fastabend@...el.com,
	Herbert Xu <herbert@...dor.apana.org.au>, tgraf@...g.ch,
	daniel@...earbox.net, chamaken@...il.com, fw@...len.de,
	dh.herrmann@...il.com
Subject: Re: [PATCH v1 0/2] basic ioctl support for netlink sockets

sent updated version. commit description should have the details. what
we are doing there is mimic what some others are doing, such as udp.c:
when returning -ENOIOCTLCMD, net/core would fallback to dev_ioctl,
which implements the NIC driver ioctls, which include ethtool ioctl.

On Sun, Mar 20, 2016 at 10:31 AM, David Miller <davem@...emloft.net> wrote:
> From: David Decotigny <ddecotig@...il.com>
> Date: Thu, 17 Mar 2016 17:03:54 -0700
>
>> This removes the requirement that ethtool be tied to the support
>> of a specific L3 protocol, also updates a comment.
>
> You're adding an ioctl handler to netlink sockets, and it is not
> at all apparent to me how this influences ethtool handling at all.
>
> Therefore you have to explain this here and in your commit message.