| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160318083236.GE6344@twins.programming.kicks-ass.net>
Date: Fri, 18 Mar 2016 09:32:36 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: kan.liang@...el.com
Cc: tglx@...utronix.de, ak@...ux.intel.com, eranian@...gle.com,
mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular
On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@...el.com wrote:
> +static void __exit intel_uncore_exit(void)
> +{
> + cpu_notifier_register_done();
Did you even test this? That should be _begin();
> + __unregister_cpu_notifier(&uncore_cpu_nb);
> + uncore_types_exit(uncore_msr_uncores);
> + uncore_pci_exit();
> + cpu_notifier_register_done();
> +}
> +module_exit(intel_uncore_exit);
> --
> 2.5.0
>
Powered by blists - more mailing lists