linux-kernel - Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1603180944320.3978@nanos>
Date:	Fri, 18 Mar 2016 09:45:30 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	kan.liang@...el.com, ak@...ux.intel.com, eranian@...gle.com,
	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular

On Fri, 18 Mar 2016, Peter Zijlstra wrote:

> On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@...el.com wrote:
> > +static void __exit intel_uncore_exit(void)
> > +{
> > +	cpu_notifier_register_done();
> 
> Did you even test this? That should be _begin();

That's my fault. I had this in my proof of concept patch and it actually works
for some reason. By some definition of works: i.e. it does not explode in your
face right away....