linux-kernel - Re: Nokia N900 - audio TPA6130A2 problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56EBD96A.8090505@ti.com>
Date:	Fri, 18 Mar 2016 12:33:14 +0200
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Sebastian Reichel <sre@...nel.org>,
	Pali Rohár <pali.rohar@...il.com>
CC:	Jarkko Nikula <jarkko.nikula@...mer.com>,
	Tony Lindgren <tony@...mide.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	Pavel Machek <pavel@....cz>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Nishanth Menon <nm@...com>, <merlijn@...zup.org>
Subject: Re: Nokia N900 - audio TPA6130A2 problems

On 03/17/16 19:26, Ivaylo Dimitrov wrote:
> Hi,
> 
>>
>> can you try this:
>> diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
>> index 11d85c5c787a..7f5881bff5d9 100644
>> --- a/sound/soc/codecs/tpa6130a2.c
>> +++ b/sound/soc/codecs/tpa6130a2.c
>> @@ -386,6 +386,8 @@ static int tpa6130a2_probe(struct i2c_client *client,
>>                  data->power_gpio = pdata->power_gpio;
>>          } else if (np) {
>>                  data->power_gpio = of_get_named_gpio(np, "power-gpio", 0);
>> +               if (data->power_gpio == -EPROBE_DEFER)
>> +                       return data->power_gpio;
>>          } else {
>>                  dev_err(dev, "Platform data not set\n");
>>                  dump_stack();
>>
> 
> 
> Doesn't help :(

it worth a try ;)

But enabling the pull via DT for the i2c2 works?

-- 
Péter